remembered credentials for NAS

[al3x]

I just found a bug with the credential feature unfortunately. I'm using the latest v5.0.0 beta_241125 version.

When you click on "Remember my credentials" the credentials are saved for the current Windows session.
But after a reboot or when you restart the HasleoBackupSuiteService service, credentials are lost.

Also: I didn't see any errors from the scheduled task or in the notification center (entries were cleared, why?), it just didn't backup anything.

Log shows this:



When trying to manually backup, the credential window shows up again:



--
*Edit 1*

Ok, some more details for this bug:
- If you setup your user and password in the main program's "Settings" (after specifying a default location for the backups), credentials are saved correctly.
- If you instead setup your user and password in the popup that shows when clicking "Backup" manually, credentials are saved for the current session only.
- So maybe the credentials for the individual jobs are not saved correctly but there's a fallback to the default location credentials? Are credentials saved per job? Don't know exactly how that works.

So the workaround for this is to set your credentials via the default location setting.
You might also need to remove the current settings in registry:
- Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Hasleo\Backup Suite\ -> DefaultImageStoragePassword

--
*Edit 2*
Individual job credentials are still saved in NetConnect.db and the default credentials are saved in registry it seems.
I opened NetConnect.db, passwords are not stored as far as I can tell. Seems like a bug:



--
*Edit 3*
Ok, sometimes the password is saved in that file and sometimes it isn't.

What I did:
- I created a new backup job after HBS installation. The default location was not yet set at this point.
- Then I created a new backup job with a network share and entered credentials for that job. NetConnect.db now holds that password.
- Now I set the default location to the same network share, HBS doesn't prompt for new credentials.

Result:
- Registry value for DefaultImageStoragePassword is now empty.
- The password in NetConnect.db is deleted.

Now you can still backup but after a reboot or service restart the credentials are missing and can't be saved permanently unless you set them again via default location.

No big deal but maybe for the future credentials should only be saved in NetConnection.db and not be mixed up with settings in registry. Then maybe implement a list in the GUI to see/delete saved credentials? Just a thought 

--
*Edit 4*
Sorry for all the edits, but something else I just saw:
- I set default location to a local folder and created a job with a network share.
- I just closed HBS, restarted the HasleoBackupSuiteService service and reopened HBS.
- There's a chance the password in NetConnect.db is now gone. Doesn't happen all the time though but eventually will after some restarts.

Something is broken, I just don't know exactly where. But passwords get deleted from NetConnect.db somewhere... 

So, bottom line is: Currently there's only 1 workaround afaik:
- Make NetConnect.db write protected. If it can't change, passwords are kept.